Fix Stale Local Backup Cache & Enrich Error Diagnostics#242
Open
patricioxavier8 wants to merge 1 commit into
Open
Fix Stale Local Backup Cache & Enrich Error Diagnostics#242patricioxavier8 wants to merge 1 commit into
patricioxavier8 wants to merge 1 commit into
Conversation
- Fixed convenience initializer in SyncedNode.swift to correctly map rootBackupFolder URL. - Implemented synchronous local database cleanup in BackupsService.swift to delete all synced nodes under the removed folder. - Enriched error logging in Error.swift to output detailed failure context and root causes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the following changes are introduced:
SyncedNoderecords are cleared from the local Realm database.cleanBackupLocalDatato be synchronous using a thread-local Realm instance. This prevents theRealm accessed from incorrect threadcrash when invoked from background threads.SyncedNode.swiftwhererootBackupFolderwas incorrectly initialized with the individual file URL instead of the root backup folder URL.Error.swiftto extractcontextandcauseinsidegetErrorDescription(). This improves diagnostic logs and simplifies mapping API failures.